[Tools v2] winetest: Get rid of $gitdir.

Alexandre Julliard julliard at winehq.org
Fri Apr 21 12:21:46 CDT 2017


Francois Gouget <fgouget at codeweavers.com> writes:

> WineHQ appears to use /home/winehq/opt/source/git/wine.git as the Wine 
> checkout directory. After this patch the scripts will use 
> $workdir/wine.git so this should most likely symlink to the above 
> location.

I'm not sure that's an improvement.

> However any non-official site will actually need write access to it from 
> the scripts to ensure that wine.git is up to date before processing 
> reports. Otherwise the reports risk being rejected due to the not yet 
> known commit id. This could still work with a placement in tools/winehq: 
> one would just have to symlink that to a writable location but it does 
> imply placing it in $workdir may make more sense.

I don't think it makes sense to put it in the website directory, it's
not meant to be accessed from the web.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list