[PATCH v2 1/2] mountmgr: Create devices and registry entries for serial ports.
Alexandre Julliard
julliard at winehq.org
Tue Apr 25 04:09:35 CDT 2017
Alex Henrie <alexhenrie24 at gmail.com> writes:
> + if (driver == serial_driver)
> + {
> + dos_name_format = comW;
> + nt_name_format = device_serialW;
> + reg_value_format = comW;
> + }
> + else
> + {
> + /* TODO: support parallel ports */
> + }
Please avoid introducing dead code. You can add the if() in the second
patch.
> + /* remove old symlinks */
> + for (n = 1; n <= MAX_PORTS; n++)
> + {
> + sprintf( p, "%u", n );
> + if (unlink( dosdevices_path ) != 0 && !errno)
> + break;
> + }
Why would errno ever be 0 here?
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list