[PATCH 2/5] ddraw: Ignore unsupported blit flags.
Henri Verbeet
hverbeet at gmail.com
Tue Apr 25 11:01:55 CDT 2017
On 25 April 2017 at 17:37, Matteo Bruni <matteo.mystral at gmail.com> wrote:
>> @@ -1577,9 +1578,26 @@ static HRESULT WINAPI DECLSPEC_HOTPATCH ddraw_surface7_Blt(IDirectDrawSurface7 *
>> TRACE("iface %p, dst_rect %s, src_surface %p, src_rect %s, flags %#x, fx %p.\n",
>> iface, wine_dbgstr_rect(dst_rect), src_surface, wine_dbgstr_rect(src_rect), flags, fx);
>>
>> - /* Check for validity of the flags here. WineD3D Has the software-opengl selection path and would have
>> - * to check at 2 places, and sometimes do double checks. This also saves the call to wined3d :-)
>> - */
>> + unsupported_flags = DDBLT_ALPHADEST
>> + | DDBLT_ALPHADESTCONSTOVERRIDE
>> + | DDBLT_ALPHADESTNEG
>> + | DDBLT_ALPHADESTSURFACEOVERRIDE
>> + | DDBLT_ALPHAEDGEBLEND
>> + | DDBLT_ALPHASRC
>> + | DDBLT_ALPHASRCCONSTOVERRIDE
>> + | DDBLT_ALPHASRCNEG
>> + | DDBLT_ALPHASRCSURFACEOVERRIDE
>> + | DDBLT_ZBUFFER
>> + | DDBLT_ZBUFFERDESTCONSTOVERRIDE
>> + | DDBLT_ZBUFFERDESTOVERRIDE
>> + | DDBLT_ZBUFFERSRCCONSTOVERRIDE
>> + | DDBLT_ZBUFFERSRCOVERRIDE;
>
> Hardly going to matter but wouldn't it be better as a static const?
>
Probably not, it's an integer constant.
More information about the wine-devel
mailing list