[PATCH 3/3] dwrite: Fix EUDC font collection use after free issue

Nikolay Sivov bunglehead at gmail.com
Thu Apr 27 09:40:17 CDT 2017


On 27.04.2017 17:04, Piotr Caban wrote:
> 
> Without this patch factory_detach_fontcollection incorrectly releases
> factory reference.
> 
> Signed-off-by: Piotr Caban <piotr at codeweavers.com>
> ---
>  dlls/dwrite/dwrite_private.h |  2 +-
>  dlls/dwrite/font.c           |  6 ++++--
>  dlls/dwrite/main.c           | 15 ++++++++-------
>  3 files changed, 13 insertions(+), 10 deletions(-)
> 

This makes sense, thanks. Please add some test for that in
test_GetEudc*, similar to what test_object_lifetime() does in the
beginning - testing that collection gets factory reference, but only once.



More information about the wine-devel mailing list