[PATCH] kernel32: Uncomment Win7 stubs in specfile.

[Sebastian Lackner]

On 08.08.2017 21:46, Zebediah Figura wrote:
> On 08/08/2017 02:42 PM, Sebastian Lackner wrote:
>> On 08.08.2017 21:38, Zebediah Figura wrote:
>>> These were originally commented since the default Windows version
>>> was still XP.
>>
>> As I see you want to increase your regression count. ;) Whats the
>> point of advertising all those functions when Wine has no
>> implementation yet?
>>
>>
> 
> I was once told the stubs in specfiles were important, but now I don't know what to believe. (Certainly they've never seemed necessary...)
> 
> I only submitted this patch because I tried to run a program and noticed warnings regarding unexported functions.
> 
> 

A lot of applications work perfectly fine when Win7+ exports are missing,
they will just assume that they are running on an old version of Windows
and use a different code path. It is therefore better to wait until the
functions are implemented before changing the spec file. For other dlls
there might be different recommendations, but for kernel32 and ntdll
there is really a very high risk of regressions when adding new stubs.

Best regards,
Sebastian