[PATCH] usp10: fall back to 'dflt' language if shaping language tag not found

Henri Verbeet hverbeet at gmail.com
Tue Aug 15 17:48:43 CDT 2017


On 15 August 2017 at 16:27, Aric Stewart <aric at codeweavers.com> wrote:
> On 8/14/17 1:27 PM, Henri Verbeet wrote:
>> On 14 August 2017 at 20:04, Aric Stewart <aric at codeweavers.com> wrote:
>>> +                script = get_opentype_script(hdc,psa,psc,FALSE);
>> Does that do anything? If I'm reading the code correctly that will set
>> it to the same value it already was. (In which case most of this would
>> simplify to "if (!script) script = MS_MAKE_TAG('l','a','t','n');")
>
> Not quite. The above loop that sets script tries twice, once with get_opentype_script(..., FALSE) then with get_opentype_script(..., TRUE) so if script is set coming into that loop it is from the TRUE loop,
>
"attempt" counts down from 2, so the first iteration has "try_new" as
TRUE, the second iteration has it as FALSE.



More information about the wine-devel mailing list