[PATCH] arm64: Use __builtin_ms_va_list and __attribute__((ms_abi)) on arm64

[Martin Storsjö]

On Wed, 16 Aug 2017, Alexandre Julliard wrote:

> André Hentschel <nerv at dawncrow.de> writes:
>
>> The upstreamed variadic function handling is terrific, thanks for that!
>> I also like this patch as logical next step, I'm just a bit worried because it locks out current builds without upgrading to an RC...
>> At the moment I'm doing winelib builds with gcc for Linux/ARM64 and clang builds for Android/ARM64.
>> It's quite easy on Linux to pick up a new clang version, not sure how long it takes until clang5 is picked up in the Android NDK...
>> On the other hand, there are not much people building Wine for ARM64, and those can pretty easily revert your patch until they are at clang5
>> OK... We need this improvement, I'll sign it off :)
>
> I'm doing Android/ARM64 builds to verify that the platform doesn't get
> broken after commit rounds, so I'll need to wait until this feature
> makes it to the Android NDK to apply the patch.

Ok, let's hope it makes its way into NDK r16. They don't use fixed 
releases of LLVM but some random snapshot plus fixes, iirc. The feature 
itself was merged around mid July, with the last fixes early August.

Since the amount of users building for arm64 probably is very small so far 
(the three of us?), I don't mind waiting until it's easily available for 
you, so we don't need to do a huge mess with compiler version 
identification for this feature in the headers.

// Martin