[PATCH] avrt: Add AvQuerySystemResponsiveness stub.

Dmitry Timoshkov dmitry at baikal.ru
Wed Aug 16 08:44:03 CDT 2017


Huw Davies <huw at codeweavers.com> wrote:

> > > > +BOOL WINAPI AvQuerySystemResponsiveness(HANDLE AvrtHandle, PULONG SystemResponsivenessValue)
> > > > +{
> > > > +    FIXME("(%p, %p): stub\n", AvrtHandle, SystemResponsivenessValue);
> > > > +    return TRUE;
> > > > +}
> > > > +
> > > 
> > > If you're going to return TRUE, you need to initialize
> > > *SystemResponsivenessValue to something meaningful.
> > > 
> > > While you're at it, we generally prefer 'ULONG *' to 'PULONG',
> > 
> > I'd guess that public APIs should follow the PSDK declarations, and
> > where PSDK has PULONG an appropriate Wine header should have ULONG
> > as well.
> 
> This isn't a header, it's the implementation.

This doesn't really matter, in order to be usable any API implementation
eventually should have a declaration in a header, and an implementation
can't have a different signature from a declaration in the public header.

> Even in a header it would be better to be more typographically
> different from the PSDK.

Uh, I'd suggest to not open a can of worms. It's better to keep
the source compatibility with PSDK as a de-facto standard.

-- 
Dmitry.



More information about the wine-devel mailing list