[v5 PATCH 1/3] dwrite: Protect cached fontface list when accessed from multiple threads

Anton Romanov theli.ua at gmail.com
Fri Aug 18 00:06:34 CDT 2017


On Thu, Aug 17, 2017 at 9:35 PM, Anton Romanov <theli.ua at gmail.com> wrote:
> And the reason it didn't crash with v1 is that the whole chain of
> releases (from fontface to factory, file, etc) was protected by lock.
> While this version releases the lock after removing fontface from the
> cache.
Sorry, this is wrong.
It actually should've crashed even with v1 (and now that I think of it
I think I did get couple of crashes in this codepath even with v1).
So I guess with this patch for w/e reason timing have changed and that
different race became more likely.
And this is fine, but fontfile should be protected as well.



More information about the wine-devel mailing list