[PATCH 4/4] shell32: Avoid a deadlock between explorer.exe and winemenubuilder.exe.

[Alexandre Julliard]

Zebediah Figura <z.figura12 at gmail.com> writes:

> Could I request an opinion on the best way to solve this problem?
>
> * The process that creates the link could be explorer, if the process
> uses the Progman DDE interface. Additionally (though perhaps
> improbably) it could be a different process than the one that creates
> the icon. I have a hard time thinking
> 5e28f7ad92e39bdd75cf291e22b7ebae00032e60 was a correct step.
> * More correct than waiting on the process handle would be waiting on
> the icon file itself using FindFirstChangeNotification() etc, but we
> can't depend on the icon ever being created.
> * Reverting 5e28f7a and using a RunOnce entry does have the
> disadvantage that it might never be run. I would personally imagine it
> acceptable to at least fix it so the link is created (if not the icon)
> but others might disagree. It would also be better if we could run
> winemenubuilder on Wine "shutdown" rather than the next startup,
> assuming this is possible. Would this solution be acceptable?

At shutdown is not much better than RunOnce, and in fact is even harder
to get right. But we could potentially make it into a service watching
the file system.

-- 
Alexandre Julliard
julliard at winehq.org