[PATCH] testbot: Don't try to use the Message-Id if the email had none.

Francois Gouget fgouget at codeweavers.com
Mon Dec 4 11:27:30 CST 2017


This can happen if one directly feeds the output of git format-patch to
the TestBot through formail, which can be useful for testing.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/Patches.pm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/testbot/lib/WineTestBot/Patches.pm b/testbot/lib/WineTestBot/Patches.pm
index b5320dc2..42118e61 100644
--- a/testbot/lib/WineTestBot/Patches.pm
+++ b/testbot/lib/WineTestBot/Patches.pm
@@ -101,9 +101,12 @@ sub FromSubmission($$)
   $self->Subject(substr($Subject, 0, $PropertyDescriptor->GetMaxLength()));
 
   my $MessageId = $Head->get("Message-Id");
-  $MessageId =~ s/\s*\n\s*/ /gs;
-  $PropertyDescriptor = $self->GetPropertyDescriptorByName("MessageId");
-  $self->MessageId(substr($MessageId, 0, $PropertyDescriptor->GetMaxLength()));
+  if ($MessageId)
+  {
+    $MessageId =~ s/\s*\n\s*/ /gs;
+    $PropertyDescriptor = $self->GetPropertyDescriptorByName("MessageId");
+    $self->MessageId(substr($MessageId, 0, $PropertyDescriptor->GetMaxLength()));
+  }
 
   $self->Disposition("Processing");
 }
-- 
2.15.0



More information about the wine-devel mailing list