[PATCH] winegstreamer: Remove redundant check

Andrew Eikum aeikum at codeweavers.com
Wed Dec 6 07:52:44 CST 2017


Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>

On Tue, Dec 05, 2017 at 12:15:01AM +0000, Alistair Leslie-Hughes wrote:
> ret is already checked above and never assigned again.
> 
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
> ---
>  dlls/winegstreamer/gstdemux.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
> index 3ef2324..95a1630 100644
> --- a/dlls/winegstreamer/gstdemux.c
> +++ b/dlls/winegstreamer/gstdemux.c
> @@ -1158,10 +1158,7 @@ static HRESULT GST_Connect(GSTInPin *pPin, IPin *pConnectPin, ALLOCATOR_PROPERTI
>      WaitForSingleObject(This->event, -1);
>      gst_element_get_state(This->container, NULL, NULL, -1);
>  
> -    if (ret < 0) {
> -        WARN("Ret: %i\n", ret);
> -        hr = E_FAIL;
> -    } else if (!This->cStreams) {
> +    if (!This->cStreams) {
>          FIXME("GStreamer could not find any streams\n");
>          hr = E_FAIL;
>      } else {
> -- 
> 1.9.1
> 
> 
> 



More information about the wine-devel mailing list