[PATCH] appwiz.cpl: Add comment explaining why we use HTTP instead of HTTPS
Alex Henrie
alexhenrie24 at gmail.com
Tue Dec 12 20:55:37 CST 2017
Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
This has come up at least twice on the mailing list because the reason
is not obvious. A comment will help the next person who has the same
question.
https://www.winehq.org/pipermail/wine-devel/2017-February/116091.html
https://www.winehq.org/pipermail/wine-devel/2017-November/120077.html
---
dlls/appwiz.cpl/addons.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dlls/appwiz.cpl/addons.c b/dlls/appwiz.cpl/addons.c
index 5ec49cfe6a..76f00a0a3b 100644
--- a/dlls/appwiz.cpl/addons.c
+++ b/dlls/appwiz.cpl/addons.c
@@ -80,6 +80,9 @@ typedef struct {
LPCWSTR dialog_template;
} addon_info_t;
+/* Download addon files over HTTP because Wine depends on an external library
+ * for TLS, so we can't be sure that HTTPS will work. The integrity of each file
+ * is checked with a hardcoded cryptographically secure hash. */
static const addon_info_t addons_info[] = {
{
GECKO_VERSION,
--
2.15.1
More information about the wine-devel
mailing list