[PATCH] ddraw/tests: Recognize E_NOTIMPL returned from UpdateOverlay

Alex Henrie alexhenrie24 at gmail.com
Thu Dec 21 23:57:24 CST 2017


2017-12-21 17:55 GMT-07:00 Francois Gouget <fgouget at free.fr>:
> On Thu, 21 Dec 2017, Alex Henrie wrote:
>
>> 2017-12-21 7:03 GMT-07:00 Henri Verbeet <hverbeet at gmail.com>:
>> > On 20 December 2017 at 07:02, Alex Henrie <alexhenrie24 at gmail.com> wrote:
>> >> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
>> >> ---
>> >> Fixes several test.winehq.org failures on Windows XP virtual machines.
>> >> ---
>> > Is that on VMware? Could you make the broken() a bit more specific? E.g:
>> >
>> >     broken(hr == E_NOTIMPL && ddraw_is_vmw_svga())
>> >
>> > See the other ddraw_is_*() helpers for how to implement ddraw_is_vmw_svga().
>>
>> I'm not sure. Francois, are fg-winxp-3sp, fg-winxp-3spie8,
>> fg-winxp-last, and fg-winxp-lusr running on VMWare? And what graphics
>> driver are they using?
>
> Yep they are running on VMware. For instance:
> https://test.winehq.org/data/68cff26b1b2d9d83b5f0a16b16f78c1b57f62ebd/xp_fg-winxp-3sp/version.html
>
> Description   Compaq's English Windows XP SP1; cleaned up and moved to
>               VMware + Creative AudioPCI + VMware Tools. Then upgraded
>               to SP2, Internet Explorer 7.0 and finally SP3 via Windows
>               Update.
>
> VMware emulates its own graphics card and I installed VMware's driver
> on Windows XP: VMware SVGA II.

Thank you Francois! I've sent new patches.

-Alex



More information about the wine-devel mailing list