winex11: Remove dead assignment (clang)

Aric Stewart aric at codeweavers.com
Wed Feb 1 08:20:39 CST 2017


Are you sure that is dead? clang must be saying so but the assignment of ximStyleCallback to ximStyle seems meaningful. Just above this code we have code that ensures that ximStyle is not 0, so if ximStyleCallback == 0 then assigning ximStyleCallback = ximStyle does not seem dead to me.

-aric


> From: André Hentschel <nerv at dawncrow.de>
> Subject: winex11: Remove dead assignment (clang)
> Message-Id: <8472d171-8b3b-04a7-62cf-a99ee7a37026 at dawncrow.de>
> Date: Mon, 30 Jan 2017 23:11:02 +0100
> 
> Signed-off-by: André Hentschel <nerv at dawncrow.de>
> ---
>  dlls/winex11.drv/xim.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c
> index e51169d..3978bca 100644
> --- a/dlls/winex11.drv/xim.c
> +++ b/dlls/winex11.drv/xim.c
> @@ -416,10 +416,7 @@ static BOOL open_xim( Display *display )
>              ximStyle = ximStyleNone;
>  
>          if (ximStyleCallback == 0)
> -        {
>              TRACE("No callback style available\n");
> -            ximStyleCallback = ximStyle;
> -        }
>  
>      }
>  
> 
> -- 
> 2.7.4



More information about the wine-devel mailing list