winex11: Remove dead assignment (clang)

Aric Stewart aric at codeweavers.com
Thu Feb 2 08:36:39 CST 2017


Interestingly as far as I can tell that code has always been dead.

Ok, I can sign off on that.

-aric

On 2/1/17 11:16 AM, André Hentschel wrote:
> Am 01.02.2017 um 17:00 schrieb Ken Thomases:
>> The "deadness" of the assignment isn't because it won't change the value of ximStyleCallback, but because nothing reads from ximStyleCallback after that point.  This looks like it needs additional review as to what the purpose of ximStyleCallback is in the first place.  Its value does change the potential code path in the preceding for loop, but that doesn't seem especially meaningful.  So, what is its purpose?
>>
>> -Ken
>>
>> On Feb 1, 2017, at 8:20 AM, Aric Stewart <aric at codeweavers.com> wrote:
>>>
>>> Are you sure that is dead? clang must be saying so but the assignment of ximStyleCallback to ximStyle seems meaningful. Just above this code we have code that ensures that ximStyle is not 0, so if ximStyleCallback == 0 then assigning ximStyleCallback = ximStyle does not seem dead to me.
>>>
> 
> Correct, at the moment it's only good for the TRACE, so if we don't need the TRACE we can remove the variable completely
> 
> 
> 
> 



More information about the wine-devel mailing list