[1/2] iphlpapi: Add GetUnicastIpAddressEntry implementation (resend)

Hans Leidekker hans at codeweavers.com
Fri Feb 3 03:22:30 CST 2017


On Fri, 2017-02-03 at 00:08 +0100, André Hentschel wrote:
> +    GetAdaptersAddresses(AF_UNSPEC, GAA_FLAG_INCLUDE_ALL_INTERFACES | GAA_FLAG_INCLUDE_PREFIX, NULL, NULL, &size);

GAA_FLAG_INCLUDE_ALL_INTERFACES has no effect on Wine and you're not using the result
of GAA_FLAG_INCLUDE_PREFIX.

> +    ptr = HeapAlloc(GetProcessHeap(), 0, size);
> +    ret = GetAdaptersAddresses(AF_UNSPEC, GAA_FLAG_INCLUDE_ALL_INTERFACES | GAA_FLAG_INCLUDE_PREFIX, NULL, ptr, &size);
> +    if (FAILED(ret))

Please handle allocation failure. GetAdaptersAddresses returns ULONG, not HRESULT.





More information about the wine-devel mailing list