[PATCH 2/2] user32: Implement BS_SPLITBUTTON and BS_DEFSPLITBUTTON.

Nikolay Sivov bunglehead at gmail.com
Mon Feb 6 04:28:28 CST 2017


On 06.02.2017 12:18, Shu Yokoyama wrote:
>>> Hi.
>>>
>>> Patch has its own problems, but more importantly, that's not the way we
>>> want v6 controls to be implemented. We need proper separation between
>>> user32 and comctl32, with corresponding versioned classes being
>>> registered at the right time, and proper classes used based on current
>>> context.
> 
> Thanks.
> I found that those have to be implemented in dlls/comctl32/theme_button.c.
> 
> Now, comctl32 buttons are registered only if theme is active (theming.c:127).
> However on Win7, if comctl32 v6 is loaded through SxS manifest,
> the buttons are registered always, whether or not IsThemeActive() is true.
> Then it might be necessary to separate comctl32.dll according to version.

Correct, theme_* files should go away eventually, and v6 classes should
not depend on whether theming is active or not. I don't need we
necessary need another separate comctl32 dll however.

> 
> 
> ----- Original Message -----
>>> From: Nikolay Sivov <bunglehead at gmail.com>
>>> To: wine-devel <wine-devel at winehq.org>
>>> Cc: yokoyama at graco.c.u-tokyo.ac.jp
>>> Date: 2017-02-06 13:19:06
>>> Subject: Re: [PATCH 2/2] user32: Implement BS_SPLITBUTTON and BS_DEFSPLITBUTTON.




More information about the wine-devel mailing list