[PATCH] msvcrt: Pass a missing flag to MSVCRT__open.
Lauri Kenttä
lauri.kentta at gmail.com
Mon Feb 6 11:32:52 CST 2017
On 2017-02-06 13:47, Piotr Caban wrote:
> On 02/04/17 14:15, Lauri Kenttä wrote:
>> int CDECL MSVCRT__creat(const char *path, int flags)
>> {
>> int usedFlags = (flags & MSVCRT__O_TEXT)| MSVCRT__O_CREAT|
>> MSVCRT__O_WRONLY| MSVCRT__O_TRUNC;
>> - return MSVCRT__open(path, usedFlags);
>> + return MSVCRT__open(path, usedFlags, MSVCRT__S_IWRITE);
>> }
> According to MSDN the function takes pmode as second argument. Could
> you please add some tests for it? It looks like wine's implementation
> is handling second argument incorrectly.
Good point. I've submitted tests and a better patch.
Thanks for your constructive feedback.
--
Lauri Kenttä
More information about the wine-devel
mailing list