[PATCH 01/2] dpnet/test: Share code between tests (resend)

[Erich E. Hoover]

On Tue, Feb 7, 2017 at 12:53 AM, Alistair Leslie-Hughes
<leslie_alistair at hotmail.com> wrote:
> ...
> Thanks for the review.
> I'm happy to rename the header  if thats all is needed to get
> it committed. I'll assume dpnet_test.h is fine unless someone else
> states something different.

No problem!  That was the thing that really stood out to me, the
consolidation you're doing looks like a really solid move (personally,
I hate duplicated code).  The only other thing that I noticed is that
is_process_elevated(), is_firewall_enabled(), and set_firewall() are
all shared with the rpcrt4 tests, so it's _possible_ for there to be a
lot more consolidation.  However, to my knowledge, we don't have a
mechanism for sharing routines like that between multiple per-dll
tests.  If someone is aware of such a mechanism then that may be a way
to make this even better.

Best,
Erich