[Tools] winetest: Add support for reports containing pids.

Alexandre Julliard julliard at winehq.org
Thu Feb 9 03:06:34 CST 2017


Francois Gouget <fgouget at codeweavers.com> writes:

> Oh! Those two:
>
> dlls/kernel32/process.c:1044:            TRACE( "started wineboot pid %04x tid %04x\n", pi.dwProcessId, pi.dwThreadId );
> dlls/kernel32/process.c:2449:        TRACE( "started process pid %04x tid %04x\n", info->dwProcessId, info->dwThreadId );
>
> Sure no problem. More janitorial work?

I was thinking more of the server traces and the +pid debug channel. I
don't think we need to cleanup the ok() traces, we should never see them
anyway.

> Do you have an opinion on the colons in the 'tests executed' 
> lines? We used to have
>
>    drive: 0 tests executed...
>
> And currently I've implemented
>
>    drive:0010 0 tests executed...
>
> rather than
>
>    drive:0010: 0 tests executed...

More bikeshedding, but 0010:drive: would be more similar to the Wine
traces, so maybe a little less confusing.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list