[PATCH 1/2] ddraw/tests: Check pointer after CreateSurface without a descriptor.

Alex Henrie alexhenrie24 at gmail.com
Mon Feb 20 00:59:35 CST 2017


2017-02-17 1:39 GMT-07:00 Stefan Dösinger <stefandoesinger at gmail.com>:
> Am 2017-02-17 um 06:05 schrieb Alex Henrie:
>>  dlls/ddraw/tests/dsurface.c | 10 ++++++++++
> The rule is to not add new things to these old files, even if it is a
> minor obvious fix. If you want to change a test in there move it to
> tests/ddraw*.c (changing the code style, using the existing helper
> functions in the file, test all versions etc) and implement the change
> there. See e.g. http://source.winehq.org/patches/data/130355 .
>
> Yeah, it's a pesky work, but it needs to be done in the long run anyway.

Unless it's really important to you, I'm not going to rewrite the
dsurface tests. The game I was debugging is fixed now, it's unlikely
to be broken again in the future, and I'd like to move on to other
bugs.

-Alex



More information about the wine-devel mailing list