[PATCH v4 15/17] x86/traps: Fixup general protection faults caused by UMIP

Ricardo Neri ricardo.neri-calderon at linux.intel.com
Fri Feb 24 13:36:19 CST 2017


On Fri, 2017-02-24 at 11:11 -0800, Andy Lutomirski wrote:
> > In a previous version Andy Lutomirsky suggested that
> >         if (user_mode(regs) && (fixup_umip_exception(regs) == 0))
> >
> > was easier to read :). Although at the time fixup_umip_exception
> > returned a numeric value. Now it only returns true/false for
> > successful/failed emulation. If with true/false not comparing to
> true
> > makes it easier to read, I will make the change.
> 
> I think == true is silly :)

Then I'll make the change.

Thanks and BR,
Ricardo




More information about the wine-devel mailing list