[PATCH 03/18] comctl32: Added basic implementation for task dialogs and add tests
Fabian Maurer
dark.shadow4 at web.de
Sat Feb 25 16:13:24 CST 2017
Thanks for the reply,
> If this will stay, please use functions, not macros. STR_SIZE does not
> look useful.
Well, I figured it makes the code a bit easier. Should I should just write it
out everywhere or make it a function?
> Usually there's no need to allocate 'struct list' itself.
You're right, I'll rewrite that.
> You can't free list node like that.
What do you mean? I allocated the list and it's contents with HeapAlloc, so I
need to free it that way. Or am I missing something?
> This one is already defined in a header.
Thanks, I'll use the headers instead of adding another define for that.
> Static string for that doesn't look right.
Why is that? I've looked into the other code, and strings are often defined as
static const WCHAR, that was the recommended method, too.
Of course that needs to be changed later, since we (probably) want to take
localization into account.
Regards,
Fabian Maurer
More information about the wine-devel
mailing list