[PATCH 4/5] server: Added server side mamed pipe read and write implementation and use it for message mode pipes.
Alexandre Julliard
julliard at winehq.org
Tue Feb 28 08:12:31 CST 2017
Sebastian Lackner <sebastian at fds-team.de> writes:
> I don't think write_process_memory is the right way to do it. This function
> also has a lot of overhead, like suspending the thread, or if /proc is not
> available reading/writing is done in chunks of sizeof(long). I'm pretty sure
> it would be faster to just transfer back the result with the same wineserver
> call. Also please note that the client side already adds a reply buffer,
> so the changes would mostly be on the server side.
Agreed. write_process_memory has many issues, and should only be used
for debugging APIs. We don't want to make it a required part of the
server protocol.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list