[PATCH v2] riched20: Check for NULL in ME_InsertTextFromCursor and add test

Huw Davies huw at codeweavers.com
Mon Jan 9 07:17:43 CST 2017


On Thu, Jan 05, 2017 at 05:06:42PM +0100, Fabian Maurer wrote:
> It already works with a null-pointer, but will crash if len is -1.
> Since null-pointer means no text, we just return to avoid crashes.
> 
> v2: Followed suggestion by Nikolay Sivov, moved check and extend test

Actually, I'd prefer the NULL ptr check in fnTextSrv_TxSetText(), where
it was in your first version.  However, the extended test is much better.

Huw.



More information about the wine-devel mailing list