`setupapi` patch from staging

[Donat Enikeev]

Hi all,

These games tested with Intel and nouveau drivers run smoothly on 
wine-staging without any additional features enabled: neither CSMT, nor 
StrictDrawOrdering (and I would suppose with this `setupapi` patch on 
plain Wine too, as it does nothing in rendering order materially, just 
making GPU rendering available). Confirmed independently on two 
distributions within the same bug #41653 (extract below)

So, as it appears, only environments with NVIDIA blob driver are 
affected. Noteworthy, that with CSMT enabled all is fine with blob as 
well (another vote for the mainline CSMT support), I believe that is 
because of single-rendering thread design.

Hope this information will help considering this setupapi patch 
reviewed. I fired a request to Nvidia support (Incident #170110-000314) 
around all of these, but wouldn't expect it to get enough attention due 
to specifics.

P.s. It would be interesting to check how AMD drivers behaves in this 
context

--- Comment #13 from Béla Gyebrószki---
nouveau/mesa 13.0.3, Wine 2.0-rc4: poor performance, no flickering
Nvidia 375.26, Wine 2.0-rc4: poor performance, no flickering

nouveau/mesa 13.0.3, Wine Staging 2.0-rc4 (CSMT=off): good performance, 
no
flickering
Nvidia 375.26, Wine Staging 2.0-rc4 (CSMT=off): good performance, 
*flickering*
nouveau/mesa 13.0.3, Wine Staging 2.0-rc4 (CSMT=on): good performance, 
no
flickering
Nvidia 375.26, Wine Staging 2.0-rc4 (CSMT=on): good performance, no 
flickering

Best,
Donnie

On Вс, янв 8, 2017 at 6:16 , Donat Enikeev <donat at enikeev.net> 
wrote:
> Hi Sebastian,
> 
> > the patch you are asking about is most likely responsible for the
> > following regression:
> > https://bugs.winehq.org/show_bug.cgi?id=41653#c11
> 
> Yes, I has been following this bug, and was able to confirm flickering
> with 2.0-rc4 without StrictDrawOrdering Wine option.
> But not sure this is a true regression (as plain Wine seems affected 
> as
> well)
> 
> Adobe Air Stage3D applications use multiple rendering Direct3D9 
> threads
> and seems Wine can't handle the commands order exactly as in Windows
> (at least for these games and/or some environments), despite all the
> syncing between threads.
> 
> So, I believe this is not a regression, the bug is just hidden per
> forced software rendering; and the trade off is between unplayability
> because of performance (see gameplay video attached
> https://bugs.winehq.org/attachment.cgi?id=56048) or flickering without
> StrictDrawOrdering on some systems
> 
> What do you think?
> 
> Best,
> Donnie
> 
> On Вс, янв 8, 2017 at 5:57 , Sebastian Lackner
> <sebastian at fds-team.de> wrote:
> > On 08.01.2017 15:52, Donat Enikeev wrote:
> >>> It was probably never sent to patch list, so there was nothing to
> >>> discuss.
> >>
> >>  Hm, so, do you think it is worth re-submitting for a formal review
> >> in current state and if so, who is eligible to do that on behalf of
> >> Michael Muller (michael at fds-team.de)?
> >>
> >>  Best regards,
> >>  Donnie
> >>
> >
> > Hi Donnie,
> >
> > the patch you are asking about is most likely responsible for the
> > following regression:
> > https://bugs.winehq.org/show_bug.cgi?id=41653#c11
> > This means it is not suitable for the development branch yet
> > (especially during the feature freeze).
> >
> > Best regards,
> > Sebastian
> >
> 
> 
>