[v2] oleaut32: Make the heap allocation functions static.

Michael Stefaniuc mstefani at redhat.com
Thu Jan 12 07:14:18 CST 2017


On 01/11/2017 09:17 PM, Alexandre Julliard wrote:
> Francois Gouget <fgouget at free.fr> writes:
> 
>> @@ -1600,26 +1600,26 @@ static void TLB_abort(void)
>>      DebugBreak();
>>  }
>>  
>> -void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size)
>> +static void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size)
>>  {
>>      void *ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size);
>>      if (!ret) ERR("cannot allocate memory\n");
>>      return ret;
>>  }
> 
> There are standard functions that I expect we'd want to use in more
> places (right Michael?)
Right.

But the Wine maintainer told me he wants those in include/wine/
And with saner semantic and error handling.
Btw. do you remember if he even promised to write the header file
portion himself?
;-P

bye
	michael



More information about the wine-devel mailing list