[PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
Dmitry Timoshkov
dmitry at baikal.ru
Thu Jan 12 20:52:57 CST 2017
Anton Romanov <theli.ua at gmail.com> wrote:
> > > +todo_wine {
> > > + enabled = 2;
> > > + ret = getsockopt(v4, IPPROTO_IPV6, IPV6_V6ONLY, (char*)&enabled,
> > &len);
> > > + ok(!ret, "getsockopt(IPV6_ONLY) failed (LastError: %d)\n",
> > WSAGetLastError());
> > > + ok(enabled == 1, "expected 1, got %d\n", enabled);
> > > +}
> >
> > The 'todo_wine' statements should be added only around ok() call that will
> > fail
> > otherwise. This applies for other places in the patch as well.
> Those OK fail in wine.
Of course, but my comment was about adding todo_wine only around the ok()
calls and nothing else.
--
Dmitry.
More information about the wine-devel
mailing list