[PATCH] programs/winhlp32: Use noyywrap for macro.lex.l

Alexandre Julliard julliard at winehq.org
Mon Jan 23 13:28:36 CST 2017


Fabian Maurer <dark.shadow4 at web.de> writes:

> On Sunday, January 22, 2017 9:22:46 PM CET Mike Swanson wrote:
>> I looked into this, and the source is related to why I made the patch in
>> the first place: it seems that flex 2.6.3 just has a bug, and I don't
>> think I can reasonably fix it so the warning doesn't appear.
>> 
>> That being said, I believe my patch is still functionally equivalent to
>> the old code and having this alternative that works with flex 2.6.3
>> should still be safe for older and newer (hopefully fixed) versions.
>
> Ah thanks, it indeed is a flex bug.
> However, it works for the other flex uses we have in wine. You could make the 
> warning disappear by using
>> %option prefix="winhlp32_"
> or something along the lines. It will rename the output files (not sure how 
> you'd deal with that), but it makes the warning go away. Also, that's the way 
> it's done in the other .l files.

FWIW the initial flex bug is now fixed by
https://github.com/westes/flex/commit/078b46c69d063aef1715b11348a2871d6036f253

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list