[PATCH 1/5] wined3d: Fix sRGB clears with no support for ARB_framebuffer_sRGB.
hverbeet at gmail.com
Fri Jan 27 15:00:37 CST 2017
On 27 January 2017 at 19:52, Matteo Bruni <mbruni at codeweavers.com> wrote:
> - if (!gl_info->supported[ARB_FRAMEBUFFER_SRGB] && needs_srgb_write(context, state, fb))
> + if (!gl_info->supported[ARB_FRAMEBUFFER_SRGB]
> + && ((!(context->d3d_info->wined3d_creation_flags & WINED3D_SRGB_READ_WRITE_CONTROL)
> + && fb->render_targets && fb->render_targets->format_flags & WINED3DFMT_FLAG_SRGB_WRITE)
> + || state->render_states[WINED3D_RS_SRGBWRITEENABLE]))
I think this looks suspicious, why is this more correct?
In particular, wouldn't this enable sRGB clears on formats without
WINED3DFMT_FLAG_SRGB_WRITE? Patch 2/5 hints that that may be
intentional, but in that case, shouldn't this be independent of
More information about the wine-devel