[PATCH 2/5] msi: Add a basic internal UI implementation.

[Zebediah Figura]

On 07/04/2017 02:14 AM, Alexandre Julliard wrote:
> Zebediah Figura <z.figura12 at gmail.com> writes:
> 
>> On 07/03/2017 09:49 PM, Marvin wrote:
>>> Hi,
>>>
>>> While running your changed tests on Windows, I think I found new failures.
>>> Being a bot and all I'm not very good at pattern recognition, so I might be
>>> wrong, but could you please double-check?
>>> Full results can be found at
>>> https://testbot.winehq.org/JobDetails.pl?Key=32025
>>>
>>> Your paranoid android.
>>>
>>>
>>> === w7u (32 bit msi) ===
>>> The task timed out
>>>
>>
>> This hang is intermittent, and seems to occur not in the added tests
>> but in test_setpropertyfolder(). The only reason I can guess why this
>> patch is relevant is that test_setpropertyfolder() also calls
>> MsiSetInternalUI.
> 
> It may be a different problem, but since a few days ago there are a lot
> of timeouts in the test results, caused by your previous round of
> changes. Could you please look into that?
> 

I'm sorry, but I can't make any sense of it. The hangs/crashes are all 
happening in completely bizarre places; all of it is in Windows code, 
and I can't find anything I'm doing wrong either. This is especially the 
case with the crash in msi.c on Win7, which happens after what seems to 
me a very unsuspicious change.