[PATCH 3/9] msvcr120: Remove precompiler check for asinh.

Alexandre Julliard julliard at winehq.org
Mon Jul 10 13:22:58 CDT 2017


Alex Henrie <alexhenrie24 at gmail.com> writes:

> If we say that C89 (or more realistically, gnu89) is the minimum
> requirement for compiling Wine, it becomes much easier to decide when
> to add (or remove) feature test macros. I'd actually like to add
> checks around several other non-C89 functions that we use in math.c.
> But the decision is up to you.

Like I said, standards are not interesting. What matters is what works
in reality, on existing systems. It wouldn't make sense to add or remove
a bunch of checks on the basis that the functions are or aren't in C89.

We have to do the checks that are necessary for Wine to build
successfully on the systems that people are using, no matter what the
standards may say.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list