[PATCH 5/7] d3dx9: Fail effect creation when shader parameter evaluator creation fails.

[Matteo Bruni]

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp at gmail.com>:

> @@ -6099,8 +6100,9 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char *
>                      {
>                          if (FAILED(hr = d3dx9_create_object(base, object)))
>                              return hr;
> -                        d3dx_create_param_eval(base, object->data, object->size, param->type,
> -                                &param->param_eval, get_version_counter_ptr(base));
> +                        if (FAILED(hr = d3dx_create_param_eval(base, object->data, object->size, param->type,
> +                                &param->param_eval, get_version_counter_ptr(base))))
> +                            return hr;
>                      }
>                      break;
>
> @@ -6138,8 +6140,11 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char *

It looks like you missed another call to d3dx_create_param_eval() in
between these two.