[PATCH 1/2] advapi32/tests: Statically link to ConvertSidToStringSidA()

Dmitry Timoshkov dmitry at baikal.ru
Tue Jul 11 04:37:22 CDT 2017


Nikolay Sivov <nsivov at codeweavers.com> wrote:

> -static BOOL (WINAPI *pConvertSidToStringSidA)( PSID pSid, LPSTR *str );
>  static BOOL (WINAPI *pConvertStringSidToSidA)( LPCSTR str, PSID pSid );
...
> -    pConvertSidToStringSidA = (void *)GetProcAddress(hmod, "ConvertSidToStringSidA");
>      pConvertStringSidToSidA = (void *)GetProcAddress(hmod, "ConvertStringSidToSidA");
...
> -    if( !pConvertSidToStringSidA || !pConvertStringSidToSidA )
> +    if( !pConvertStringSidToSidA )

What's so special about ConvertSidToStringSidA and why same logic won't
apply to ConvertStringSidToSidA and possibly others?

-- 
Dmitry.



More information about the wine-devel mailing list