[PATCH 7/9] msvcr120: Add erfc.

Alex Henrie alexhenrie24 at gmail.com
Tue Jul 11 10:04:11 CDT 2017


2017-07-11 6:31 GMT-06:00 Piotr Caban <piotr.caban at gmail.com>:
> On 07/11/17 14:11, Piotr Caban wrote:
>>
>> On 07/10/17 06:55, Alex Henrie wrote:
>>>
>>>   /*********************************************************************
>>> + *      erfc (MSVCR120.@)
>>> + */
>>> +double CDECL MSVCR120_erfc(double x)
>>> +{
>>> +#ifdef HAVE_ERFC
>>> +    return erfc(x);
>>> +#else
>>> +    FIXME( "not implemented\n" );
>>> +    return 0.0;
>>> +#endif
>>
>> You can return 1.0 - MSVCR120_erf(x) if erfc is not available.
>
> After thinking about it more I don't know if it's better to print FIXME or
> return inaccurate value when erf(x) is close to 1. How about returning
> approximate value and printing FIXME message?

I don't think there are any systems that have erf but not erfc, and I
don't want a call to erfc to print two FIXMEs. Returning 0 should be
fine.

-Alex



More information about the wine-devel mailing list