winhttp: Rename host_t to hostdata_t.

Henri Verbeet hverbeet at gmail.com
Wed Jul 19 10:55:47 CDT 2017


On 19 July 2017 at 17:22, Sebastian Lackner <sebastian at fds-team.de> wrote:
> Commit fa2cc9868b7db7a4cbf7d01a48500cb3f31e109a broke the compilation macOS
> because host_t conflicts with a system header file:
>
> [19:31:41] In file included from ../../../wine/dlls/winhttp/session.c:50:
> [19:31:41] ../../../wine/dlls/winhttp/winhttp_private.h:106:3: error: typedef redefinition with different types ('struct host_t' vs 'mach_port_t' (aka 'unsigned int'))
> [19:31:41] } host_t;
> [19:31:41]   ^
> [19:31:41] /build/macos-rootfs/usr/include/mach/mach_types.h:120:22: note: previous definition is here
> [19:31:41] typedef mach_port_t             host_t;
> [19:31:41]                                 ^
>
It may be too late for winhttp or Wine in general (although Michael
does love these kinds of things), but note that the _t suffix is
reserved by POSIX and should in principle be avoided on POSIX systems.



More information about the wine-devel mailing list