[PATCH 2/7] regedit: Use a helper function to allocate memory and check for a valid pointer

Hugh McMaster hugh.mcmaster at outlook.com
Wed Jul 26 23:22:36 CDT 2017


On Thursday, 27 July 2017 2:41 AM, Alexandre Julliard wrote:
> That's not the standard heap_alloc(), so a different name would be
> preferable. I'd suggest heap_xalloc by analogy with xmalloc.

"Standard" would be a function just returning HeapAlloc(...), right?

And you did mention the 'x' prefix a few days ago. Totally missed that
in the patch.

By the way, regedit should exit(0), but perhaps exit(1) - as in the patch -
is still more appropriate for allocation failure?

Thanks for the help.



More information about the wine-devel mailing list