[PATCH 2/7] regedit: Use a helper function to allocate memory and check for a valid pointer
Alexandre Julliard
julliard at winehq.org
Thu Jul 27 02:37:18 CDT 2017
Hugh McMaster <hugh.mcmaster at outlook.com> writes:
> On Thursday, 27 July 2017 2:41 AM, Alexandre Julliard wrote:
>> That's not the standard heap_alloc(), so a different name would be
>> preferable. I'd suggest heap_xalloc by analogy with xmalloc.
>
> "Standard" would be a function just returning HeapAlloc(...), right?
Yes, the one that we use in many places, and that Michael is going to
move to a global header any day now ;-)
> By the way, regedit should exit(0), but perhaps exit(1) - as in the patch -
> is still more appropriate for allocation failure?
Sure.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list