[PATCH] wmvcore/tests: add tests for WMReader methods
Alistair Leslie-Hughes
leslie_alistair at hotmail.com
Thu Jul 27 04:07:38 CDT 2017
Hi Jefferson,
Thanks for the updated patch.
When applying your patch there lot of whitespace errors (mostly from the
header).
warning: squelched 3569 whitespace errors
warning: 3574 lines add whitespace errors.
After look at qedit/tests, include the wma directly as a resource.
(unless someone else objects)
>// MSDN says dwType is a QWORD, but it is actually a DWORD
C++ style comments aren't allowed.
> ok(dwType == WMT_TYPE_DWORD, "onStatus pValue not WMT_TYPE_QWORD (%d),
but %d\n", (int)WMT_TYPE_DWORD, dwType);
Again WMT_TYPE_QWORD is incorrect here, and remove the
(int)WMT_TYPE_DWORD parameter.
TestWMReaderCallback_AddRef/Release could just return 2/1 respectfully.
The object doesn't need to be deleted nor is there any reference type
checks.
wmvcore.c: In function ‘test_wmreader_play_wma’:
wmvcore.c:425:8: warning: cast from pointer to integer of different size
[-Wpointer-to-int-cast]
ok((int)(onStatus_event = CreateEventW(NULL, FALSE, FALSE, NULL)),
"Could not create event\n");
^
You dont delete the wma file.
Best Regards
Alistair Leslie-Hughes
More information about the wine-devel
mailing list