[PATCH 1/3] uiribbon: Add DLL

Fabian Maurer dark.shadow4 at web.de
Fri Jul 28 09:27:40 CDT 2017


Hello Alistair,

Thanks for the quick feedback.

> 1. Add new dll (DLLMain and private functions)

Should I add all private functions like DllGetClassObject as stub, or already 
implemented? Because the class factory logic is is a bunch of code, that's why 
I separated it from the initial commit.

> 2. Add idl to include (Including all the interfaces required)

Just for clarification, I should add all the needed interfaces (including 
IUIApplication) at once in the idl, but only add the IUnknown methods into 
IUIFramework_Vtbl?

I'll fix the other issues, and also a few style inconsistencies I noticed. I'm 
also working on tests, but I figured it makes sense to have a stubbed 
implementation first.

Regards,
Fabian Maurer



More information about the wine-devel mailing list