[PATCH v4 2/3] uiribbon: Add interface definitions

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Sun Jul 30 01:10:17 CDT 2017


Hi Fabian,

Besides the below issues, the patches look good.

On 30/07/17 09:29, Fabian Maurer wrote:
> Signed-off-by: Fabian Maurer <dark.shadow4 at web.de>

> +[
> +    object,
> +    uuid(D428903C-729A-491d-910D-682A08FF2522),
Please make the uuid lowercase

...
> +[
> +    object,
> +    uuid(F4F0385D-6872-43a8-AD09-4C339CB3F5C5),
> +    local,
> +    pointer_default(unique)
Please make the uuid lowercase
Also, could you please get rid of the LPVOID in the third patch.

Best Regards
 Alistair Leslie-Hughes


More information about the wine-devel mailing list