[PATCH v3] comctl32/taskdialog: Implement buttons.

Fabian Maurer dark.shadow4 at web.de
Sun Jun 11 13:38:45 CDT 2017


Many thanks for looking into it, looks a lot better now.

I just noticed another issue in my code though. The line
> int new_alignment = desc->dialog_width - (DIALOG_SPACING + line_widths[i]);
has to be
> int new_alignment = desc->dialog_width - line_widths[i];

After all, we've already calculated DIALOG_SPACING for the right side into the 
width of the line, so we shouldn't subtract it again.

This fixes the left alignment, without the change it doesn't respect dialog 
spacing to the left.
If you don't object that change, feel free to submit it.

Just a small question, what compiler warning did my original code produce? I 
didn't get one, and maybe I need to change my setup.

Regards,
Fabian Maurer



More information about the wine-devel mailing list