[PATCH 3/6] server: Implement changing the label of a security descriptor.

Matteo Bruni matteo.mystral at gmail.com
Tue Jun 13 17:57:58 CDT 2017


2017-06-13 22:34 GMT+02:00 Sebastian Lackner <sebastian at fds-team.de>:
> On 13.06.2017 22:12, Sebastian Lackner wrote:
>> On 13.06.2017 21:00, Alexandre Julliard wrote:
>>> Matteo Bruni <mbruni at codeweavers.com> writes:
>>>
>>>> From: Michael Müller <michael at fds-team.de>
>>>>
>>>> Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
>>>> ---
>>>>  dlls/advapi32/tests/security.c | 153 ++++++++++++++++++++++++++++++++++++++++-
>>>>  dlls/ntdll/sec.c               |   3 +-
>>>>  server/handle.c                | 130 +++++++++++++++++++++++++++++++++-
>>>>  3 files changed, 282 insertions(+), 4 deletions(-)
>>> It doesn't work here:
>>> [...]
>> I can't test it right now, but I suspect that this is caused by a change done by Matteo Bruni in patch 2.
>>
>>> +    if (!count) return 1;
>>> +
>> This wasn't present yet in Michael Müllers original patchset.
>>
>> Best regards,
>> Sebastian
>>
>
> It is indeed caused by this specific change, so it probably makes sense to hold back patch 2 aswell.
> @Matteo: Was there any specific reason for this change?
>
> Best regards,
> Sebastian

No, it was a last-minute change (I think it was to avoid malloc(0) but
clearly there's no such danger) and apparently I didn't retest the
patches after adding it. So double fail.

I'll send the fixed and retested patches soon.



More information about the wine-devel mailing list