[PATCH 2/2] comctl32/propsheet: Implement PSPCB_ADDREF/PSPCB_RELEASE notifications

Nikolay Sivov bunglehead at gmail.com
Wed Mar 1 22:45:21 CST 2017


On 02.03.2017 6:13, Dmitry Timoshkov wrote:
> Nikolay Sivov <nsivov at codeweavers.com> wrote:
> 
>> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
>> ---
>>  dlls/comctl32/propsheet.c       | 41 +++++++++++++++++++++++++++++++++++------
>>  dlls/comctl32/tests/propsheet.c |  4 ----
>>  2 files changed, 35 insertions(+), 10 deletions(-)
> 
> And of course it's a pure coincidence that you immediately started to work on
> PSPCB_ADDREF/PSPCB_RELEASE once a patch for it has been added to wine-staging.

Why should or shouldn't it be? What does it have to do with a patch? I
worked on getting another propsheet fix tracked in wine-staging in, as
well as some of my own. Simply because I care about fixes getting into
Wine, you - apparently not so much.

> I'd suggest to stop such ill-behaved practices, or at least give a credit to
> the source if you decided to "borrow" an idea. Or is this an indication that
> you just ran out of your own ideas to work on? :)
> 

I would gladly give a credit for it, if it worked in a first place.
Since it couldn't possibly work, and behavior is well documented, I
don't think it qualifies as an idea on its own.

Now, to get all the credit you can possibly get, because that's
obviously is the most important thing there is, there is a way that
you're well aware of.



More information about the wine-devel mailing list