[PATCH v2 2/5] winebus.sys: Build device reports for linux event devices

Aric Stewart aric at codeweavers.com
Thu Mar 2 13:01:39 CST 2017



On 3/2/17 12:34 AM, Roderick Colenbrander wrote:
> Hi Aric,
> 
> I have had a quick look over this patch and have some initial
> feedback, maybe more later if time permits.
> 
> For the absolute and relative axes don't hard code the minimum and
> maximum values for the report descriptors. These are not correct for
> many devices e.g. Xbox controllers use 16-bit absolute axes, while
> DS3/DS4 for example use 8-bit. In addition xbox controllers use signed
> data, while DS3/DS4 use unsigned (0-255)Also many devices use signed
> data.
> 
> You should rely on the absinfo data returned by EVIOCGABS and base
> your input ranges on that.
> 
> Thanks,
> Roderick
> 

Hi Rodrick,

Thanks for looking at these, your input is very valuable given all your experience. 

I am a bit swamped right at the moment so I will need a moment to circle back but any in depth review you give will not be ignored. I would love to get this part working.

-aric

> On Mon, Feb 27, 2017 at 9:32 AM, Aric Stewart <aric at codeweavers.com> wrote:
>>
>> v2: Updates from Sebastian Lackner
>>
>> Signed-off-by: Aric Stewart <aric at codeweavers.com>
>> ---
>>  dlls/winebus.sys/bus_udev.c | 438 +++++++++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 436 insertions(+), 2 deletions(-)
>>
>>
>>
>>
>>



More information about the wine-devel mailing list