[PATCH] crypt32/tests: Fix a memory leak in testFindCRL.

Alex Henrie alexhenrie24 at gmail.com
Tue Mar 7 23:38:41 CST 2017


2017-03-07 7:03 GMT-07:00 Erich E. Hoover <erich.e.hoover at wine-staging.com>:
> On Sun, Feb 26, 2017 at 11:52 PM, Alex Henrie <alexhenrie24 at gmail.com> wrote:
>> ...
>> +    store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, 0,
>> +                          CERT_STORE_CREATE_NEW_FLAG, NULL);
>> +    if (!store) return;
>> +
>> ...
>
> Would you mind adding an error when this happens?  Otherwise we may
> not know that these tests did not run.

Sure. Should that be a win_skip statement or an ok statement? Is there
ever a case when we expect CertOpenStore to fail?

-Alex



More information about the wine-devel mailing list