[PATCH 3/5] usp10: Use heap_alloc_zero() instead of HeapAlloc() with HEAP_ZERO_MEMORY.

Henri Verbeet hverbeet at gmail.com
Thu Mar 9 09:02:00 CST 2017


On 9 March 2017 at 15:51, Sebastian Lackner <sebastian at fds-team.de> wrote:
> On 09.03.2017 10:37, Henri Verbeet wrote:
>> -static inline BOOL heap_free(void *mem)
>> -{
>> -    return HeapFree(GetProcessHeap(), 0, mem);
>> -}
> [...]
>> +static inline void heap_free(void *mem)
>> +{
>> +    HeapFree(GetProcessHeap(), 0, mem);
>> +}
>
> I'm not sure if Francois is happy with this change. In other dlls, he
> has made the exact opposite change in his effort to standardize those
> functions.
>
I wasn't aware of that. While I don't care particularly much if it's
there or not, I'd be somewhat surprised if there are legitimate uses
of the return value. At least inside usp10 it's always ignored.



More information about the wine-devel mailing list