[PATCH 1/2] comctl32/propsheet: Diverse UI fixes

[Nikolay Sivov]

On 10.03.2017 1:17, Nikolay Sivov wrote:
> On 09.03.2017 23:19, Hermès BÉLUSCA-MAÏTO wrote:
>> [PATCH 1/2] comctl32/propsheet: Diverse UI fixes:
>>
>> - Draw static text elements with a transparent background, so that they
>> acquire the correct background color of the wizard window.
>>
>> - Modify the check for the header bitmap, as the header's hbmHeader is
>> initialized also if the flag PSH_HEADER but not PSH_USEHBMHEADER is set
>> (see function PROPSHEET_LoadWizardBitmaps).
>>
>> - Add a check for header's hbmWatermark so that the watermark is drawn
>> only when a valid bitmap handle is present. - Fix a copy-pasta error
>> when drawing the header's subtitle.
>>
>>
>>
>>
> 
> Hi, Hermès.
> 
> Thanks for the patches, some comments follow.
> 
>>      case WM_CTLCOLORSTATIC:
>> -      SetBkColor((HDC)wParam, GetSysColor(COLOR_WINDOW));
>> -      return (INT_PTR)GetSysColorBrush(COLOR_WINDOW);
>> +      SetBkMode((HDC)wParam, TRANSPARENT);
>> +      return (INT_PTR)GetStockObject(HOLLOW_BRUSH);
>>    }
> 

Forgot to mention, looks like NULL_BRUSH is preferred, I don't see
HOLLOW_BRUSH being used anywhere in Wine.