[v3 06/12] comctl32: TaskDialog - make thread-safe
Fabian Maurer
dark.shadow4 at web.de
Fri Mar 10 16:10:55 CST 2017
On Freitag, 10. März 2017 23:06:11 CET Nikolay Sivov wrote:
> On 10.03.2017 21:21, Fabian Maurer wrote:
> > +
> > +typedef struct
> > +{
> > + const TASKDIALOGCONFIG *task_config;
> > + HWND hwnd;
> > +}taskdialog_info;
>
> It doesn't look very safe to keep original pointer here. If you only
> need callback pointer and user callback data, store them directly.
I certainly could do that if you think that's better.
But why unsafe? The pointer should be valid until TaskDialogIndirect returns,
shouldn't it?
Regards,
Fabian Maurer
More information about the wine-devel
mailing list